updates

atorus-research · Aug 20, 2024 · 00a5b28 · 00a5b28
1 parent 49e242e
commit 00a5b28
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -2,7 +2,7 @@
 
 ## xportr development version
 
-* New argument in `xportr_write()` allows users to specify the maximum file size (in gb) of their exported xpt files. (#268)
+* New argument in `xportr_write()` allows users to specify the maximum file size (in GB) of their exported xpt files. (#268)
 
 ## New Features
 

diff --git a/R/write.R b/R/write.R
@@ -7,7 +7,7 @@
 #' @param .df A data frame to write.
 #' @param path Path where transport file will be written. File name sans will be
 #'   used as `xpt` name.
-#' @param max_size_gb Maximum size in gb of the exported files
+#' @param max_size_gb Maximum size in GB of the exported files.
 #' @param label `r lifecycle::badge("deprecated")` Previously used to to set the Dataset label.
 #' Use the `metadata` argument to set the dataset label.
 #' @param strict_checks If TRUE, xpt validation will report errors and not write
@@ -151,8 +151,8 @@ get_split_path <- function(path, ind) {
 #' Function to export data frame to xpt files ensuring each file does not exceed the maximum specified size in GB
 #'
 #' @param df A data frame to write.
-#' @param max_size_gb Maximum size in gb of the exported files
-#' @param file_prefix Name of each exported file
+#' @param max_size_gb Maximum size in GB of the exported files.
+#' @param file_prefix Name of each exported file.
 #'
 #' @noRd
 

diff --git a/man/xportr_write.Rd b/man/xportr_write.Rd
diff --git a/tests/testthat/test-write.R b/tests/testthat/test-write.R
@@ -230,27 +230,27 @@ test_that("write Test 14: `max_size_gb` is used to split data frame into specifi
 
   expect_true(
     file.exists(file.path(tmpdir, "adlb1.xpt")),
-    file.info(file.path(tmpdir, "adlb1.xpt"))$size <= as.numeric(format(max_size_gb * 10^9, scientific = F))
+    file.info(file.path(tmpdir, "adlb1.xpt"))$size <= as.numeric(format(max_size_gb * 10^9, scientific = FALSE))
   )
 
   expect_true(
     file.exists(file.path(tmpdir, "adlb2.xpt")),
-    file.info(file.path(tmpdir, "adlb2.xpt"))$size <= as.numeric(format(max_size_gb * 10^9, scientific = F))
+    file.info(file.path(tmpdir, "adlb2.xpt"))$size <= as.numeric(format(max_size_gb * 10^9, scientific = FALSE))
   )
 
   expect_true(
     file.exists(file.path(tmpdir, "adlb3.xpt")),
-    file.info(file.path(tmpdir, "adlb3.xpt"))$size <= as.numeric(format(max_size_gb * 10^9, scientific = F))
+    file.info(file.path(tmpdir, "adlb3.xpt"))$size <= as.numeric(format(max_size_gb * 10^9, scientific = FALSE))
   )
 
   expect_true(
     file.exists(file.path(tmpdir, "adlb4.xpt")),
-    file.info(file.path(tmpdir, "adlb4.xpt"))$size <= as.numeric(format(max_size_gb * 10^9, scientific = F))
+    file.info(file.path(tmpdir, "adlb4.xpt"))$size <= as.numeric(format(max_size_gb * 10^9, scientific = FALSE))
   )
 
   expect_true(
     file.exists(file.path(tmpdir, "adlb5.xpt")),
-    file.info(file.path(tmpdir, "adlb5.xpt"))$size <= as.numeric(format(max_size_gb * 10^9, scientific = F))
+    file.info(file.path(tmpdir, "adlb5.xpt"))$size <= as.numeric(format(max_size_gb * 10^9, scientific = FALSE))
   )
 })