Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: cargo deny on push/pull requests #370

Merged
merged 13 commits into from
Jan 29, 2025

Conversation

maschad
Copy link
Member

@maschad maschad commented Jan 27, 2025

We really should run this on PRs as per the README

@maschad maschad self-assigned this Jan 27, 2025
@maschad maschad marked this pull request as draft January 27, 2025 22:49
Copy link
Contributor

@jorgeantonio21 jorgeantonio21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maschad
Copy link
Member Author

maschad commented Jan 28, 2025

Thanks @jorgeantonio21 I will still fix some of these advisories and bans before merging though, so that at least we have a passing build

@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
atoma-bin/atoma_node.rs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files with missing lines Coverage Δ
atoma-bin/atoma_node.rs 0.00% <0.00%> (ø)

@maschad maschad added the sui label Jan 29, 2025
@maschad maschad marked this pull request as ready for review January 29, 2025 02:13
Copy link
Contributor

@jorgeantonio21 jorgeantonio21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jorgeantonio21 jorgeantonio21 merged commit 48459e1 into atoma-network:main Jan 29, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants