refactor model trait method signatures #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 7, 2024
jorgeantonio21
changed the title
Merged
Cifko
reviewed
Apr 8, 2024
| } | ||
|
|
||
| #[derive(Clone, Debug, Serialize, Deserialize)] | ||
| pub enum ModelType { |
There was a problem hiding this comment.
I don't like the idea that model type is inside the models models. Models should just know their version. They shouldn't be aware of any other model, but with this structure they are. Enum of enums would be a better solution.
There was a problem hiding this comment.
I agree with this. Let's merge this PR and address this issue in a future PR.
|
It would be nice if you split PRs like these. The review is getting messy when unrelated things are combined into a single PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This longer PR addresses the following:
ModelTraitmethods into something that seems more compatible and less verbose.StableDiffusionmodel, to decouple loading the unet, vae and text embedding models from running inference.ModelServicegeneral enough to support multiple thread models, without being stucked with a single model (enforced previously by theM: ModelTraitassociated type).