-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds mamba model integration with thread model #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method in now takes ownership of by using instead of , ensuring exclusive access to the thread's state during execution. Refactor MambaModel to implement run method The struct in now implements the method of the trait. The method is refactored to handle input parameters and generate output accordingly. It utilizes the tokenizer to encode the prompt, generates tokens using the model, and constructs the output string based on the generated tokens. Introduce TokenOutputStream A new module is introduced in to define the struct. This struct handles tokenization and decoding of model outputs. Update mod.rs to include token_output_stream The file in the module is updated to include the module, enabling access to the struct. Update service.rs to use mutable reference in run method The method of the struct in is updated to take a mutable reference to , ensuring that it can modify the internal state if necessary.
Cifko
reviewed
Apr 2, 2024
Cifko
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on PR #12