This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
[FEATURE/FIX] Ensuring NodeJS 12 Compatibility #315
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👟 Description & Background
As this Pull Request is not addressing a specific functional issue in code, but rather constitutes a list of fixes to enable the use of this module with a NodeJS 12 context. Currently, referencing
text-buffer
in NodeJS 12 projects leads to cascading (and hard-to-decipher) build errors in downstream text editing apps like slap. Underlying reasons are build configuration issues, an incompatible upstream dependency and code style issues, and are all being adressed by the PR.👟 Steps to Reproduce (S2R)
npm -g install 'https://github.com/cancerberoSgx/slap'
🤷🏽♂️ Main Issues
atom/substring
causes problems in a nodejs 12 environment🎯 Conducted Changes
node_modules
binaries ofcoffeescript
,rimraf
orcpy
prepublish
phase because it does not get called when installing modules from Git (and due to deprecation). Theprepare
phase now used initiates the compilation process during installations regardless of context.🏡 Context
Version Tested
v13.17.0
Installation Approach
nvm, npm
Operating System
Apple macOS Mojave 10.14.6