This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Add support text to user-following interface. #395
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay @barraponto -
Can you update the issue body to add a screenshot of the before and after for this change? |
5892088052
approved these changes
Jul 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
The User (Site) following UI lacks support text -- users have to figure out what clicking the user avatar does. I believe some instructional title text, displayed on hover, is a small step in improving this UI.
Alternate Designs
Title text is a small step towards better UX. I believe we can further improve by displaying notifications on follow / unfollow. Scrolling or changing tabs makes a following user stop following, but the only feedback is the disappearance of the link icon over the followed user avatar.
Benefits
Users will become aware of what the sites-ui (user avatars) are meant for.
Possible Drawbacks
Don't foresee any drawback.
Verification Process
I installed Teletype and jumped to
~/.atom/packages/teletypeand performed the changes directly there. Restarted Atom and the title text was displayed as expected. Following/Unfollowing was reflected in the title text.