Add match for exact path ref #158 #237
Conversation
|
@eMerzh Can you please add some specs for this? Thanks. |
spec/fuzzy-finder-spec.coffee
Outdated
| @@ -585,6 +585,20 @@ describe 'FuzzyFinder', -> | |||
| expect(atom.workspace.panelForItem(projectView).isVisible()).toBe false | |||
| expect(inputView).toHaveFocus() | |||
|
|
|||
| describe "when the filter text contains an absolute path", -> | |||
| it "it matches the given path", -> | |||
There was a problem hiding this comment.
No need for a double it. it "matches the given path" is fine.
There was a problem hiding this comment.
thanks for the review,
not sure about your comment, you suggest to replace
describe "when the filter text contains an absolute path", ->
it "it matches the given path", ->by
it "it matches the given path", ->?
There was a problem hiding this comment.
He's suggesting replace:
it "it matches the given path", ->with
it "matches the given path", -"You don't need to use the word it twice in the same line 😀
|
Let's say I input |
|
hum... nothing now... EDIT: ok might have found :) |
|
did i broke the tests? they all run ok on my machine |
|
Don't worry about the tests. |
| @@ -585,6 +585,20 @@ describe 'FuzzyFinder', -> | |||
| expect(atom.workspace.panelForItem(projectView).isVisible()).toBe false | |||
| expect(inputView).toHaveFocus() | |||
|
|
|||
| describe "when the filter text contains an absolute path", -> | |||
There was a problem hiding this comment.
Now that relative paths are supported, can you also add a test for that?
There was a problem hiding this comment.
it's not really relative.... it's "normalized" , you can't do like ../current_file.html
although it could be interesting
but you cant do
~/.atom/config.cson or /home/me/../hello
|
is there something i can do to help this PR moving ? |
Hi,
i'm really new in the atom dev / coffee and all,
but here is a small itch that i had using atom..
trying to past full path in the fuzzy finder and not having the ability to open the path directly...
might not be the place or the best way ....
The idea is that like :
what do you think?