Skip to content
This repository has been archived by the owner on Jul 23, 2019. It is now read-only.

set up the benchmark on xray-core #62

Merged
merged 4 commits into from
Apr 12, 2018

Conversation

rleungx
Copy link
Contributor

@rleungx rleungx commented Apr 11, 2018

This PR use criterion to set up the benchmark on xray-core.
See #21.

@nathansobo
Copy link

Cool! Thanks for this. I made a couple adjustments:

  • Avoiding making buffer a public field of BufferView
  • Updated the docs to mention benchmarks (and made some other changes while I was at it)
  • Set up the benchmarks to run on Travis to avoid them bit-rotting.

Glad you got this started. Now adding new benchmarks will be a lot easier without having to figure out how to set it up. ⚡️

@nathansobo nathansobo merged commit 62b9481 into atom-archive:master Apr 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants