Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ft: seller of the product, delete the product #42

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

ft: seller of the product, delete the product #42

wants to merge 7 commits into from

Conversation

jeandamas
Copy link
Collaborator

@jeandamas jeandamas commented Mar 15, 2023 •
edited
Loading

About PR:
This PR creates a feature that allows the seller who owns the product to delete the product.

  • Create product delete controller
  • Create the /products/delete/{ProductID} route
  • Use middleware to check if there is a logged-in seller
  • Use the controller to check if the logged-in seller owns the product
  • Return the Deleted product or error message

@jeandamas jeandamas added the Under Review Ready to be reviewed label Mar 15, 2023
TresorRw
TresorRw previously approved these changes Mar 15, 2023
View reviewed changes
fabrice-rw
fabrice-rw previously approved these changes Mar 15, 2023
View reviewed changes
Rukundojoseph
Rukundojoseph previously approved these changes Mar 15, 2023
View reviewed changes
@jeandamas jeandamas added READY Ready to be merged and removed Under Review Ready to be reviewed labels Mar 15, 2023
@jeandamas jeandamas dismissed stale reviews from Rukundojoseph, fabrice-rw, and TresorRw via 49b04b1 March 16, 2023 11:39
TresorRw
TresorRw previously approved these changes Mar 16, 2023
View reviewed changes
@jeandamas jeandamas added WIP Work in Progress and removed READY Ready to be merged labels Mar 17, 2023
TresorRw
TresorRw previously approved these changes Mar 17, 2023
View reviewed changes
rachelumwari
rachelumwari previously approved these changes Mar 17, 2023
View reviewed changes
@jeandamas jeandamas dismissed stale reviews from rachelumwari and TresorRw via 8233e49 March 17, 2023 16:05
@jeandamas jeandamas added READY Ready to be merged and removed WIP Work in Progress labels Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rukundojoseph Rukundojoseph Rukundojoseph left review comments

@rachelumwari rachelumwari rachelumwari left review comments

@fabrice-rw fabrice-rw fabrice-rw left review comments

@TresorRw TresorRw TresorRw left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
READY Ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jeandamas @TresorRw @fabrice-rw @rachelumwari @Rukundojoseph