Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Deployment Envs #280

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Fix Deployment Envs #280

merged 3 commits into from
Dec 3, 2024

Conversation

ndahimana154
Copy link
Member

No description provided.

Copy link

vercel bot commented Nov 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
atlp-devpulse-fn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 1:14pm

Copy link
Contributor

@ceelogre ceelogre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Connect this to the main backend.

@ndahimana154
Copy link
Member Author

Connect this to the main backend.

Completed.

@ceelogre ceelogre self-requested a review December 3, 2024 12:48
Comment on lines 78 to 79
docker ps | grep "$container_id" || exit 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to check the status of the container since you already got the ID and the if block did not run.

Copy link

codeclimate bot commented Dec 3, 2024

Code Climate has analyzed commit 755f299 and detected 0 issues on this pull request.

View more on Code Climate.

@ceelogre ceelogre merged commit 70ce042 into develop Dec 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants