Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix apply job post #277

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix apply job post #277

wants to merge 1 commit into from
+114 −21

Conversation

jkarenzi
Copy link
Contributor

@jkarenzi jkarenzi commented Nov 29, 2024 •
edited
Loading

What does this PR do?

  • This PR incorporates feedback and changes that were requested

Description of the task to be completed

  • Disable buttons when form validation fails
  • Add word count to rich text editor
  • Fix minor design issues
  • Add comments for 'rejected' status and remove 'submitted' status

How can this be manually tested?

  • Log in with [email protected] and password as password123
  • Apply to any job post. Try to re-apply to the same job post. The button should display 'view details' and not 'apply'
  • Log in with [email protected] and password as password123
  • View the details of any application
  • Change the application status to rejected. You should be prompted to provide additional comments

Screenshots

qwqw qaqa

@vercel Vercel
Copy link

vercel bot commented Nov 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
atlp-devpulse-fn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 1, 2024 9:47am

@jkarenzi jkarenzi added the WIP work in progress label Nov 29, 2024
@jkarenzi
fix(apply-jobpost): incorporate feedback
1beac2b 
- disable buttons whn form validation fails
- add word count to rich text editor
- fix minor design issues
@codeclimate CodeClimate
Copy link

codeclimate bot commented Dec 1, 2024

Code Climate has analyzed commit 1beac2b and detected 0 issues on this pull request.

View more on Code Climate.

@jkarenzi jkarenzi added Ready For Review Extra attention is needed and removed WIP work in progress labels Dec 2, 2024
@Prince-Kid Prince-Kid added the DREAM DREAM TEAM label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncutixavier ncutixavier Awaiting requested review from ncutixavier

@Ismaelmurekezi Ismaelmurekezi Awaiting requested review from Ismaelmurekezi

@SaddockAime SaddockAime Awaiting requested review from SaddockAime

@hbapte hbapte Awaiting requested review from hbapte

@Mugisha146 Mugisha146 Awaiting requested review from Mugisha146

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
DREAM DREAM TEAM Ready For Review Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkarenzi @Prince-Kid