Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic incident sort functionality #1049

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Add basic incident sort functionality #1049

merged 1 commit into from
Nov 4, 2024

Conversation

noah-schechter
Copy link
Collaborator

Current
We offer three sort options in search: 1) recently modified, 2) alphabetical incident description, and 3) recently created.

Proposed
Users would also like to be able to sort by incident date.

Implementation notes
There are two design decisions here:

  1. First, how to name these options concisely? I decided to use "Incident Date (Most Recent)" and "Incident Date (Least Recent)". There may be a better name for each option.
  2. Second, how to order incidents without a date? I've gone ahead with Ecto's default sorting for null values, but there may be an option that is preferable here.

Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for atlos-docs canceled.

Name Link
🔨 Latest commit b63a8b6
🔍 Latest deploy log https://app.netlify.com/sites/atlos-docs/deploys/67192ac0471de30008b9af5c

@milesmcc milesmcc merged commit f80db18 into main Nov 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants