Migrate to aws sdk 2 for cloudwatch/aws cloud provider #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akavatl
changed the title
akavatl
changed the title
irisgve
reviewed
Nov 6, 2024
irisgve
reviewed
Nov 6, 2024
hstan
reviewed
Nov 6, 2024
|
|
||
| p.logger.WithField("ips", IP).Debug("Looking up instances") | ||
| err := p.Ec2.DescribeInstancesPagesWithContext(ctx, input, func(page *ec2.DescribeInstancesOutput, lastPage bool) bool { | ||
| hasPagesRemaining := true | ||
| for hasPagesRemaining { | ||
| pages++ |
There was a problem hiding this comment.
I know this is unchanged but just wondering if it should count a page if the describe failed later
There was a problem hiding this comment.
Fair question, don't have a strong opinion tbh
hstan
reviewed
Nov 6, 2024
…unneeded Ec2Client type
|
@akavatl should we move to ready for review now? |
|
@irisgve Yes I will, I want to do some deeper testing but it shouldn't block this being reviewed(just being merged) |
irisgve
previously approved these changes
Nov 7, 2024
irisgve
previously approved these changes
Nov 8, 2024
irisgve
reviewed
Nov 8, 2024
Makefile
Outdated
| @@ -66,14 +66,14 @@ build-gostatsd-fips: | |||
| build-lambda-fips: | |||
| @$(MAKE) build PKG=$(LAMBDA_PKG) BINARY_NAME="lambda-extension" GOBUILD_OPTIONAL_FLAGS="-tags fips" | |||
|
|
|||
| build-all: pb/gostatsd.pb.go tools | |||
There was a problem hiding this comment.
This should be fine to leave here since build-all covers building the proto
irisgve
previously approved these changes
Nov 8, 2024
akavatl
force-pushed
the
migrate-to-aws-sdk-2
branch
from
15edf35
to
383f932
Compare
irisgve
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.