Minor fix - Remove returning AtlanError while making a request (#31)

* Minor fix - Remove returning AtlanError while making request Signed-off-by: Karanjot Singh <[email protected]> * Return instead of AtlanError in throwatlanerror Signed-off-by: Karanjot Singh <[email protected]> * Return connection error on making a delete request Signed-off-by: Karanjot Singh <[email protected]> --------- Signed-off-by: Karanjot Singh <[email protected]>
atlanhq · May 28, 2024 · 56e6065 · 56e6065
1 parent cd7e289
commit 56e6065
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/atlan/client/client.go b/atlan/client/client.go
@@ -233,7 +233,7 @@ func (ac *AtlanClient) makeRequest(method, path string, params map[string]interf
 	case http.MethodGet:
 		req, err = http.NewRequest(method, path, nil)
 		if err != nil {
-			ThrowAtlanError(err, CONNECTION_ERROR, nil)
+			return nil, ThrowAtlanError(err, CONNECTION_ERROR, nil)
 		}
 	case http.MethodPost, http.MethodPut:
 		body, ok := params["data"].(io.Reader)
@@ -242,7 +242,7 @@ func (ac *AtlanClient) makeRequest(method, path string, params map[string]interf
 		}
 		req, err = http.NewRequest(method, path, body)
 		if err != nil {
-			ThrowAtlanError(err, CONNECTION_ERROR, nil)
+			return nil, ThrowAtlanError(err, CONNECTION_ERROR, nil)
 		}
 		req.Header.Set("Content-Type", "application/json")
 	case http.MethodDelete:
@@ -256,7 +256,7 @@ func (ac *AtlanClient) makeRequest(method, path string, params map[string]interf
 		}
 		req, err = http.NewRequest(method, path, body)
 		if err != nil {
-			ThrowAtlanError(err, CONNECTION_ERROR, nil)
+			return nil, ThrowAtlanError(err, CONNECTION_ERROR, nil)
 		}
 		if body != nil {
 			req.Header.Set("Content-Type", "application/json")

diff --git a/atlan/client/errors.go b/atlan/client/errors.go
@@ -710,7 +710,7 @@ func handleApiError(response *http.Response, originalError error) error {
 	return nil
 }
 
-func ThrowAtlanError(err error, sdkError ErrorCode, suggestion *string, args ...interface{}) *AtlanError {
+func ThrowAtlanError(err error, sdkError ErrorCode, suggestion *string, args ...interface{}) error {
 	atlanError := AtlanError{
 		ErrorCode: errorCodes[sdkError],
 	}