Test CI using Oracle v18 until v23 NLS_COMP is fixed (#2177)

atk4 · Feb 24, 2024 · 67bc0c6 · 67bc0c6
1 parent a2dc6b7
commit 67bc0c6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/.github/workflows/test-unit.yml b/.github/workflows/test-unit.yml
@@ -94,7 +94,7 @@ jobs:
         image: mariadb
         options: --health-cmd="mariadb-admin ping" --health-interval=10s --health-timeout=5s --health-retries=5 -e MYSQL_ROOT_PASSWORD=atk4_pass_root -e MYSQL_USER=atk4_test_user -e MYSQL_PASSWORD=atk4_pass -e MYSQL_DATABASE=atk4_test
       postgres:
-        image: postgres
+        image: postgres:alpine
         env:
           POSTGRES_USER: atk4_test_user
           POSTGRES_PASSWORD: atk4_pass
@@ -106,7 +106,7 @@ jobs:
           ACCEPT_EULA: Y
           SA_PASSWORD: atk4_pass
       oracle:
-        image: gvenzl/oracle-free
+        image: gvenzl/oracle-xe:18-slim-faststart
         env:
           ORACLE_PASSWORD: atk4_pass
     steps:
@@ -258,7 +258,7 @@ jobs:
         image: mariadb
         options: --health-cmd="mariadb-admin ping" --health-interval=10s --health-timeout=5s --health-retries=5 -e MYSQL_ROOT_PASSWORD=atk4_pass_root -e MYSQL_USER=atk4_test_user -e MYSQL_PASSWORD=atk4_pass -e MYSQL_DATABASE=atk4_test
       postgres:
-        image: postgres
+        image: postgres:alpine
         env:
           POSTGRES_USER: atk4_test_user
           POSTGRES_PASSWORD: atk4_pass
@@ -270,7 +270,7 @@ jobs:
           ACCEPT_EULA: Y
           SA_PASSWORD: atk4_pass
       oracle:
-        image: gvenzl/oracle-free
+        image: gvenzl/oracle-xe:18-slim-faststart
         env:
           ORACLE_PASSWORD: atk4_pass
     steps:

diff --git a/demos/_unit-test/late-output-error.php b/demos/_unit-test/late-output-error.php
@@ -16,7 +16,7 @@
 
 $emitLateErrorHFx = static function () {
     // TODO once https://github.com/php/php-src/issues/12385 is fixed
-    // while (ob_get_level() !== 0) {
+    // while (ob_get_level() > 0) {
     //     ob_end_flush();
     // }
     header('x-unmanaged-header: test');