minor demo improvement

atk4 · Feb 17, 2024 · 4353e14 · 4353e14
1 parent 2f729ea
commit 4353e14
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/demos/collection/multitable.php b/demos/collection/multitable.php
@@ -47,7 +47,7 @@ public function setModel(Model $model, array $route = []): void
         $table = Table::addTo($this->addColumn(), ['header' => false, 'class.very basic selectable' => true])->setStyle('cursor', 'pointer');
         $table->setModel($model, [$model->titleField]);
 
-        $selections = $this->explodeSelectionValue($this->getApp()->tryGetRequestQueryParam($this->name) ?? '');
+        $selectionIds = $this->explodeSelectionValue($this->getApp()->tryGetRequestQueryParam($this->name) ?? '');
 
         $makeJsReloadFx = function (array $path): JsReload {
             return new JsReload($this, [$this->name => new JsExpression('[] + []', [
@@ -60,15 +60,15 @@ public function setModel(Model $model, array $route = []): void
         $jsReload = $makeJsReloadFx($path);
         $table->on('click', 'tr', $jsReload);
 
-        while ($id = array_shift($selections)) {
+        foreach ($selectionIds as $id) {
             $table->js(true)->find('tr[data-id=' . $this->getApp()->uiPersistence->typecastAttributeSaveField($this->model->getField($this->model->idField), $id) . ']')->addClass('active');
 
             $path[] = $this->getApp()->uiPersistence->typecastAttributeSaveField($this->model->getField($this->model->idField), $id);
             $pushModel = new $model($model->getPersistence());
             $pushModel = $pushModel->load($id);
 
             $ref = array_shift($route);
-            if (!$route) {
+            if ($route === []) {
                 $route[] = $ref; // repeat last route
             }