Skip to content

Commit

Permalink
Make "__atk_tab" GET param non-sticky (#2191)
Browse files Browse the repository at this point in the history
  • Loading branch information
mvorisek authored Mar 27, 2024
1 parent cb95074 commit 41884cd
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 0 additions & 1 deletion src/App.php
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,6 @@ class App
/** @var array<string, bool> global sticky arguments */
protected array $stickyGetArguments = [
'__atk_json' => false,
'__atk_tab' => false,
];

/** @var class-string */
Expand Down
2 changes: 1 addition & 1 deletion tests/DemosTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ protected function assertNoGlobalSticky(App $app): void
{
$appSticky = array_diff_assoc(
\Closure::bind(static fn () => $app->stickyGetArguments, null, App::class)(),
['__atk_json' => false, '__atk_tab' => false, 'APP_CALL_EXIT' => true, 'APP_CATCH_EXCEPTIONS' => true]
['__atk_json' => false, 'APP_CALL_EXIT' => true, 'APP_CATCH_EXCEPTIONS' => true]
);
if ($appSticky !== []) {
throw (new Exception('Global GET sticky must never be set by any component'))
Expand Down

0 comments on commit 41884cd

Please sign in to comment.