Skip to content

Commit

Permalink
better phpstan fix
Browse files Browse the repository at this point in the history
  • Loading branch information
mvorisek committed Mar 26, 2024
1 parent 91f4fdc commit 03ead7d
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion src/Card.php
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
* will have it's idField set as data-id HTML attribute for the card. Thus making
* the ID available via javascript (new Jquery())->data('id')
*
* @property false|null $model use $entity property instead TODO remove null once https://github.com/phpstan/phpstan/issues/10787 is fixed
* @property false $model use $entity property instead
*/
class Card extends View
{
Expand Down
2 changes: 1 addition & 1 deletion src/CardTable.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
* IMPORTANT: Although the purpose of the "Card" component will remain the same, we do plan to
* improve implementation of a card to to use https://fomantic-ui.com/views/card.html .
*
* @property false|null $model use $entity property instead TODO remove null once https://github.com/phpstan/phpstan/issues/10787 is fixed
* @property false $model use $entity property instead
*/
class CardTable extends Table
{
Expand Down
2 changes: 1 addition & 1 deletion src/Form.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
use Atk4\Ui\Js\JsExpressionable;

/**
* @property false|null $model use $entity property instead TODO remove null once https://github.com/phpstan/phpstan/issues/10787 is fixed
* @property false $model use $entity property instead
*/
class Form extends View
{
Expand Down
2 changes: 1 addition & 1 deletion src/Form/AbstractLayout.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
/**
* Custom Layout for a form.
*
* @property false|null $model use $entity property instead TODO remove null once https://github.com/phpstan/phpstan/issues/10787 is fixed
* @property false $model use $entity property instead
*/
abstract class AbstractLayout extends View
{
Expand Down
4 changes: 2 additions & 2 deletions src/View.php
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ public function __construct($label = [])
* Do not try to create your own "Model" implementation, instead you must be looking for
* your own "Persistence" implementation.
*
* @phpstan-assert !null $this->model
* @XXXphpstan-assert !null $this->model TODO enable once https://github.com/phpstan/phpstan/issues/10787 is fixed
*/
public function setModel(Model $model): void
{
Expand All @@ -137,7 +137,7 @@ public function setModel(Model $model): void
*
* @param array $fields Limit model to particular fields
*
* @phpstan-assert !null $this->model
* @phpstan-assert !null $this->model TODO enable once https://github.com/phpstan/phpstan/issues/10787 is fixed
*/
public function setSource(array $data, $fields = null): Model
{
Expand Down
2 changes: 1 addition & 1 deletion src/VueComponent/InlineEdit.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
/**
* A Simple inline editable text Vue component.
*
* @property false|null $model use $entity property instead TODO remove null once https://github.com/phpstan/phpstan/issues/10787 is fixed
* @property false $model use $entity property instead
*/
class InlineEdit extends View
{
Expand Down

0 comments on commit 03ead7d

Please sign in to comment.