fix coverage #30407
Workflow file for this run
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| name: Unit | |
| on: | |
| pull_request: | |
| push: | |
| schedule: | |
| - cron: '0 0/2 * * *' | |
| jobs: | |
| smoke-test: | |
| name: Smoke | |
| runs-on: ubuntu-latest | |
| container: | |
| image: ghcr.io/mvorisek/image-php:${{ matrix.php }} | |
| strategy: | |
| fail-fast: false | |
| matrix: | |
| php: ['latest'] | |
| type: ['Phpunit'] | |
| include: | |
| - php: 'latest' | |
| type: 'StaticAnalysis' | |
| steps: | |
| - name: Checkout | |
| uses: actions/checkout@v4 | |
| - name: Configure PHP | |
| run: | | |
| rm /usr/local/etc/php/conf.d/docker-php-ext-xdebug.ini | |
| php --version | |
| - name: Setup cache 1/2 | |
| id: composer-cache | |
| run: | | |
| echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT | |
| - name: Setup cache 2/2 | |
| uses: actions/cache@v4 | |
| with: | |
| path: ${{ steps.composer-cache.outputs.dir }} | |
| key: ${{ runner.os }}-composer-smoke-${{ matrix.php }}-${{ matrix.type }}-${{ hashFiles('composer.json') }} | |
| restore-keys: | | |
| ${{ runner.os }}-composer- | |
| - name: Install PHP dependencies | |
| run: | | |
| if [ "${{ matrix.type }}" != "Phpunit" ] && [ "${{ matrix.type }}" != "StaticAnalysis" ]; then composer remove --no-interaction --no-update phpunit/phpunit ergebnis/phpunit-slow-test-detector --dev; fi | |
| if [ "${{ matrix.type }}" != "CodingStyle" ]; then composer remove --no-interaction --no-update friendsofphp/php-cs-fixer ergebnis/composer-normalize --dev; fi | |
| if [ "${{ matrix.type }}" != "StaticAnalysis" ]; then composer remove --no-interaction --no-update phpstan/\* behat/\* --dev; fi | |
| composer update --ansi --prefer-dist --no-interaction --no-progress --optimize-autoloader | |
| - name: "Run tests: SQLite (only for Phpunit)" | |
| if: startsWith(matrix.type, 'Phpunit') | |
| run: | | |
| php demos/_demo-data/create-db.php | |
| vendor/bin/phpunit --exclude-group none --no-coverage --fail-on-warning --fail-on-risky $(if vendor/bin/phpunit --version | grep -q '^PHPUnit 9\.'; then echo -v; else echo --fail-on-notice --fail-on-deprecation --display-notices --display-deprecations --display-warnings --display-errors --display-incomplete --display-skipped; fi) | |
| - name: Check Coding Style (only for CodingStyle) | |
| if: matrix.type == 'CodingStyle' | |
| run: | | |
| if [ "$(find demos/ -name '*.php' -print0 | xargs -0 grep -L "namespace Atk4\\\\Ui\\\\Demos[;\\\\]" | tee /dev/fd/2)" ]; then echo 'All demos/ files must have namespace declared' && (exit 1); fi | |
| vendor/bin/php-cs-fixer fix --dry-run --using-cache=no --diff --verbose | |
| composer config --unset version && composer config --unset require-release | |
| composer validate --strict --no-check-lock && composer normalize --dry-run --no-check-lock | |
| - name: Run Static Analysis (only for StaticAnalysis) | |
| if: matrix.type == 'StaticAnalysis' | |
| run: | | |
| echo "memory_limit = 2G" > /usr/local/etc/php/conf.d/custom-memory-limit.ini | |
| vendor/bin/phpstan analyse | |
| unit-test: | |
| name: Unit | |
| runs-on: ubuntu-latest | |
| container: | |
| image: ghcr.io/mvorisek/image-php:${{ matrix.php }} | |
| strategy: | |
| fail-fast: false | |
| matrix: | |
| php: ['7.4', '8.3'] | |
| type: ['Phpunit'] | |
| include: | |
| - php: 'latest' | |
| type: 'Phpunit Burn' | |
| env: | |
| LOG_COVERAGE: "${{ fromJSON('{true: \"1\", false: \"\"}')[matrix.php == '8.3' && matrix.type == 'Phpunit' && (github.event_name == 'pull_request' || (github.event_name == 'push' && (github.ref == 'refs/heads/develop' || github.ref == 'refs/heads/master')))] }}" | |
| steps: | |
| - name: Checkout | |
| uses: actions/checkout@v4 | |
| - name: Configure PHP | |
| run: | | |
| if [ -n "$LOG_COVERAGE" ]; then echo "xdebug.mode=coverage" >> /usr/local/etc/php/conf.d/docker-php-ext-xdebug.ini; else rm /usr/local/etc/php/conf.d/docker-php-ext-xdebug.ini; fi | |
| php --version | |
| - name: Setup cache 1/2 | |
| id: composer-cache | |
| run: | | |
| echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT | |
| - name: Setup cache 2/2 | |
| uses: actions/cache@v4 | |
| with: | |
| path: ${{ steps.composer-cache.outputs.dir }} | |
| key: ${{ runner.os }}-composer-${{ matrix.php }}-${{ matrix.type }}-${{ hashFiles('composer.json') }} | |
| restore-keys: | | |
| ${{ runner.os }}-composer- | |
| - name: Install PHP dependencies | |
| run: | | |
| if [ "${{ matrix.type }}" != "Phpunit" ] && [ "${{ matrix.type }}" != "Phpunit Lowest" ] && [ "${{ matrix.type }}" != "Phpunit Burn" ]; then composer remove --no-interaction --no-update phpunit/phpunit ergebnis/phpunit-slow-test-detector --dev; fi | |
| if [ "${{ matrix.type }}" != "CodingStyle" ]; then composer remove --no-interaction --no-update friendsofphp/php-cs-fixer ergebnis/composer-normalize --dev; fi | |
| if [ "${{ matrix.type }}" != "StaticAnalysis" ]; then composer remove --no-interaction --no-update phpstan/\* behat/\* --dev; fi | |
| if [ -n "$LOG_COVERAGE" ]; then composer require --no-interaction --no-install phpunit/phpcov; fi | |
| composer update --ansi --prefer-dist --no-interaction --no-progress --optimize-autoloader | |
| if [ "${{ matrix.type }}" = "Phpunit Lowest" ]; then composer update --ansi --prefer-dist --prefer-lowest --prefer-stable --no-interaction --no-progress --optimize-autoloader; fi | |
| if [ "${{ matrix.type }}" = "Phpunit Burn" ]; then sed -i 's~public function runBare(): void~public function runBare(): void { gc_collect_cycles(); $memDiffs = array_fill(0, '"$(if [ \"$GITHUB_EVENT_NAME\" == \"schedule\" ]; then echo 64; else echo 16; fi)"', 0); $emitter = Event\\Facade::emitter(); for ($i = -1; $i < count($memDiffs); ++$i) { $this->_runBare(); if ($this->inIsolation) { $dispatcher = \\Closure::bind(static fn () => $emitter->dispatcher, null, Event\\DispatchingEmitter::class)(); if ($i === -1) { $dispatcherEvents = $dispatcher->flush()->asArray(); } else { $dispatcher->flush(); } foreach ($dispatcherEvents as $event) { $dispatcher->dispatch($event); } } gc_collect_cycles(); $mem = memory_get_usage(); if ($i !== -1) { $memDiffs[$i] = $mem - $memPrev; } $memPrev = $mem; rsort($memDiffs); if (array_sum($memDiffs) >= 4096 * 1024 || $memDiffs[2] > 0) { $e = new AssertionFailedError("Memory leak detected! (" . implode(" + ", array_map(static fn ($v) => number_format($v / 1024, 3, ".", " "), array_filter($memDiffs))) . " KB, " . ($i + 2) . " iterations)"); $this->status = TestStatus::failure($e->getMessage()); $emitter->testFailed($this->valueObjectForEvents(), Event\\Code\\ThrowableBuilder::from($e), Event\\Code\\ComparisonFailureBuilder::from($e)); $this->onNotSuccessfulTest($e); } } } private function _runBare(): void~' vendor/phpunit/phpunit/src/Framework/TestCase.php && cat vendor/phpunit/phpunit/src/Framework/TestCase.php | grep '_runBare('; fi | |
| - name: Init | |
| run: | | |
| if [ -n "$LOG_COVERAGE" ]; then mkdir coverage; fi | |
| - name: "Run tests: SQLite" | |
| run: | | |
| php demos/_demo-data/create-db.php | |
| php -d opcache.enable_cli=1 vendor/bin/phpunit --exclude-group none $(if [ -n "$LOG_COVERAGE" ]; then echo --coverage-text; else echo --no-coverage; fi) --fail-on-warning --fail-on-risky $(if vendor/bin/phpunit --version | grep -q '^PHPUnit 9\.'; then echo -v; else echo --fail-on-notice --fail-on-deprecation --display-notices --display-deprecations --display-warnings --display-errors --display-incomplete --display-skipped; fi) | |
| if [ -n "$LOG_COVERAGE" ]; then mv coverage/phpunit.cov coverage/phpunit-sqlite.cov; fi | |
| behat-test: | |
| name: Behat | |
| runs-on: ubuntu-latest | |
| container: | |
| image: ghcr.io/mvorisek/image-php:${{ matrix.php }}-selenium | |
| strategy: | |
| fail-fast: false | |
| matrix: | |
| php: ['8.1', '8.3'] | |
| type: ['Chrome'] | |
| include: | |
| - php: 'latest' | |
| type: 'Firefox' | |
| env: | |
| LOG_COVERAGE: "${{ fromJSON('{true: \"1\", false: \"\"}')[matrix.php == '8.3' && matrix.type == 'Chrome' && (github.event_name == 'pull_request' || (github.event_name == 'push' && (github.ref == 'refs/heads/develop' || github.ref == 'refs/heads/master')))] }}" | |
| steps: | |
| - name: Checkout | |
| uses: actions/checkout@v4 | |
| - name: Configure PHP | |
| run: | | |
| if [ -n "$LOG_COVERAGE" ]; then echo "xdebug.mode=coverage" >> /usr/local/etc/php/conf.d/docker-php-ext-xdebug.ini; else rm /usr/local/etc/php/conf.d/docker-php-ext-xdebug.ini; fi | |
| php --version | |
| - name: Setup cache 1/2 | |
| id: composer-cache | |
| run: | | |
| echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT | |
| - name: Setup cache 2/2 | |
| uses: actions/cache@v4 | |
| with: | |
| path: ${{ steps.composer-cache.outputs.dir }} | |
| key: ${{ runner.os }}-composer-behat-${{ matrix.php }}-${{ matrix.type }}-${{ hashFiles('composer.json') }} | |
| restore-keys: | | |
| ${{ runner.os }}-composer- | |
| - name: Install PHP dependencies | |
| run: | | |
| composer remove --no-interaction --no-update phpunit/phpunit ergebnis/phpunit-slow-test-detector --dev | |
| composer remove --no-interaction --no-update friendsofphp/php-cs-fixer ergebnis/composer-normalize --dev | |
| composer remove --no-interaction --no-update phpstan/\* --dev | |
| if [ -n "$LOG_COVERAGE" ]; then composer require --no-interaction --no-install phpunit/phpcov; fi | |
| composer update --ansi --prefer-dist --no-interaction --no-progress --optimize-autoloader | |
| if [ "${{ matrix.type }}" = "Chrome Lowest" ]; then composer update --ansi --prefer-dist --prefer-lowest --prefer-stable --no-interaction --no-progress --optimize-autoloader; fi | |
| - name: Init | |
| run: | | |
| if [ -n "$LOG_COVERAGE" ]; then mkdir coverage coverage/js; fi | |
| ci_wait_until () { timeout 30 sh -c "until { $1 2> /dev/null; }; do sleep 0.02; done" || timeout 15 sh -c "$1" || { echo "health timeout: $1"; exit 1; }; } | |
| php -d opcache.enable_cli=1 -S 127.0.0.1:8888 > /dev/null 2>&1 & | |
| ci_wait_until 'nc -w 1 127.0.0.1 8888' | |
| if [ -f /etc/alpine-release ]; then addgroup browser && adduser browser -G browser -D -s /bin/sh; else adduser browser --gecos "" --disabled-login -shell /bin/sh > /dev/null; fi | |
| { Xvfb -ac :99 -screen 0 1920x1200x24 2> /dev/null & } && export DISPLAY=:99 | |
| ci_wait_until '[ -e /tmp/.X11-unix/X99 ]' | |
| su browser -c 'java -Dwebdriver.chrome.whitelistedIps=127.0.0.1 -jar /opt/selenium-server-standalone.jar -role standalone -host 127.0.0.1 -port 4444 -sessionTimeout 15 -browserTimeout 12 > /dev/null 2>&1 &' | |
| ci_wait_until 'nc -w 1 127.0.0.1 4444' | |
| if [ "${{ matrix.type }}" = "Firefox" ] || [ "${{ matrix.type }}" = "Firefox Slow" ]; then sed -i "s~chrome~firefox~" behat.yml.dist; fi | |
| if [ "${{ matrix.type }}" = "Chrome Slow" ] || [ "${{ matrix.type }}" = "Firefox Slow" ]; then echo 'usleep(500_000);' >> demos/init-app.php; fi | |
| - name: "Run tests: SQLite" | |
| run: | | |
| php demos/_demo-data/create-db.php | |
| vendor/bin/behat -vv --config behat.yml.dist | |
| - name: aaa | |
| uses: actions/upload-artifact@v4 | |
| with: | |
| name: aaa | |
| path: coverage/ | |
| - name: Upload coverage logs 1/2 (only for coverage) | |
| if: env.LOG_COVERAGE | |
| run: | | |
| ls -lah coverage | |
| ls -lah coverage/js | |
| ls -l coverage | wc -l | |
| echo xxx1 | |
| - name: bbb | |
| uses: actions/upload-artifact@v4 | |
| with: | |
| name: bbb | |
| path: coverage/ | |
| - name: Upload coverage logs 1/2 (only for coverage) B | |
| if: env.LOG_COVERAGE | |
| run: | | |
| ls -l coverage/js | wc -l | |
| (cd js && npx nyc report --temp-dir ../coverage/js --report-dir ../coverage/js -e vue --reporter=clover) | |
| echo xxx3 | |
| # fix never reached condition is rendered to clover with falsecount > 0 | |
| # https://github.com/istanbuljs/istanbuljs/issues/695 | |
| sed -i -E 's~count="0" type="cond" truecount="0" falsecount="[1-9]+[0-9]*"~count="0" type="cond" truecount="0" falsecount="0"~' coverage/js/clover.xml | |
| sed -i -E 's~count="[0-9]+" type="cond" truecount="[1-9]+[0-9]*" falsecount="[0-9]+"~count="1" type="cond" truecount="1" falsecount="1"~' coverage/js/clover.xml | |
| - name: Upload coverage logs 2/2 (only for coverage) | |
| if: env.LOG_COVERAGE | |
| uses: codecov/codecov-action@v3 | |
| with: | |
| token: ${{ secrets.CODECOV_TOKEN }} | |
| fail_ci_if_error: true | |
| files: coverage/js/clover.xml |