Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hasOne type mismatch for FileField #45

Merged
merged 4 commits into from
Dec 7, 2023
Merged

Fix hasOne type mismatch for FileField #45

merged 4 commits into from
Dec 7, 2023

Conversation

mkrecek234
Copy link
Contributor

Fix hasOne type mismatch error for FileField ensuring same type for both parent token and child fields

mvorisek
mvorisek reviewed Dec 7, 2023
View reviewed changes
src/Field/FileField.php Outdated Show resolved Hide resolved
@mvorisek
Copy link
Member

mvorisek commented Dec 7, 2023

CI is outdated and must be fixed first.

@mvorisek mvorisek merged commit 1b7bdca into develop Dec 7, 2023
6 checks passed
@mvorisek mvorisek deleted the fix_hasOne_type branch December 7, 2023 12:50
@mvorisek
Copy link
Member

mvorisek commented Dec 7, 2023

Thank you!

@mvorisek mvorisek mentioned this pull request Dec 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvorisek mvorisek mvorisek left review comments

@romaninsh romaninsh Awaiting requested review from romaninsh

@DarkSide666 DarkSide666 Awaiting requested review from DarkSide666

@abbadon1334 abbadon1334 Awaiting requested review from abbadon1334

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkrecek234 @mvorisek