Refactor references NS to use consistent and explicit variable and method names #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgehristov
force-pushed
the
refactor/references-var-names
branch
from
0faf920 to
47c3d37
Compare
georgehristov
force-pushed
the
refactor/references-var-names
branch
from
47c3d37 to
b985e52
Compare
mvorisek
reviewed
Jul 25, 2020
mvorisek
reviewed
Jul 25, 2020
mvorisek
reviewed
Jul 25, 2020
mvorisek
reviewed
Jul 25, 2020
mvorisek
reviewed
Jul 25, 2020
mvorisek
reviewed
Jul 25, 2020
mvorisek
reviewed
Jul 25, 2020
mvorisek
reviewed
Jul 25, 2020
src/Reference/ContainsOne.php
Outdated
|
|
||
| return $p; | ||
| return new Persistence\ArrayOfStrings([$this->getTableAlias() => $row ? [1 => $row] : []]); |
mvorisek
reviewed
Jul 25, 2020
src/Reference/HasMany.php
Outdated
| $ourModel = $this->getOurModel(); | ||
|
|
||
| return $this->getTheirModel($defaults)->addCondition( | ||
| $this->their_field ?: ($ourModel->table . '_' . ($ourModel->id_field ?: 'id')), |
There was a problem hiding this comment.
we should have more like two protected methods for build and parse (I think related with table alias regexes above)
There was a problem hiding this comment.
Also here - feel free to implement your ideas in this PR
There was a problem hiding this comment.
related with #675 (comment) , this should be probably solved in this PR
There was a problem hiding this comment.
This PR is about pure renaming. Let's merge this PR and you look into it when you have time and willingness for it.
mvorisek
reviewed
Jul 25, 2020
mvorisek
reviewed
Jul 25, 2020
mvorisek
reviewed
Jul 25, 2020
georgehristov
force-pushed
the
refactor/references-var-names
branch
from
b2c69db to
5196ace
Compare
georgehristov
force-pushed
the
refactor/references-var-names
branch
from
8ceefb5 to
e2121cb
Compare
|
@mvorisek let's merge this now as pure var name refactoring. |
DarkSide666
approved these changes
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to solving #662