Rename BasicCondition to Condition #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
changed the title
mvorisek
force-pushed
the
scope_improve_usability
branch
from
640a198 to
64db209
Compare
mvorisek
force-pushed
the
scope_improve_usability
branch
from
64db209 to
8edad00
Compare
mvorisek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is difference between CompoundCondition and Scope? Currently, Scope is topmost "scope". Everything else is "condition", but one is basic, onother is compound, ...
To simplify the terminology and reduce the number of terms, I propose to:
a) keep CompoundCondition more like an implementation detail and call collection of conditions aScope. If it is part of Scope, we can call it$subscopeor with specific name like$customerScope.b) rename BasicCondition to
Condition. Then if we speak about condition, we speak about the basic/simple one. Like in a real world, condition is undivisible