Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add curtains #212

Merged
merged 4 commits into from
Sep 12, 2024
Merged

Add curtains #212

merged 4 commits into from
Sep 12, 2024

Conversation

JELoohuis
Copy link
Collaborator

@JELoohuis JELoohuis commented Sep 11, 2024

  • Added support for curtain devices
    Added support for 'cl' Tuya devices.
    The following capabilities were implemented:

    • control (windowcoverings_state)
    • mach_operate (windowcoverings_state)
    • position (windowcoverings_set)
    • percent_control (windowcoverings_set)
    • percent_state (windowcoverings_set)

    The following capabilities were implemented as settings:

    • opposite (inverse)
    • control_back (inverse)
    • control_back_mode (inverse)

    No device was available to test these capabilities

Copy link
Collaborator

@bobvandevijver bobvandevijver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't checked the code, but you only implemented the position code, which is legacy. All requested devices use percent_control.

@bobvandevijver bobvandevijver linked an issue Sep 12, 2024 that may be closed by this pull request
@bobvandevijver bobvandevijver merged commit 91fb596 into athombv:next Sep 12, 2024
3 checks passed
@bobvandevijver bobvandevijver deleted the add-curtains branch September 12, 2024 12:19
@bobvandevijver bobvandevijver added the enhancement New feature or request label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
2 participants