Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings maintenance #202

Merged
merged 5 commits into from
Sep 5, 2024
Merged

Conversation

JELoohuis
Copy link
Collaborator

@JELoohuis JELoohuis commented Sep 5, 2024

  • Fixed setting types
    Some types for device settings were not up to date, or missing altogether. The missing settings have been added, and setting handlers updated accordingly.

  • Migrated dimmer and light setting handlers
    These drivers now use the setting handler in utils, instead of their own slightly different duplicate of the code.

@bobvandevijver bobvandevijver added the bug Something isn't working label Sep 5, 2024
@bobvandevijver bobvandevijver added this to the Release 1.3.x milestone Sep 5, 2024
@bobvandevijver bobvandevijver marked this pull request as ready for review September 5, 2024 20:30
@bobvandevijver bobvandevijver merged commit 433de2d into athombv:master Sep 5, 2024
3 checks passed
@bobvandevijver bobvandevijver deleted the settings-maintenance branch September 5, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

2 participants