Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IconicFontButton and supporting code. #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

niedzielski
Copy link

This PR adds support for a new class, IconicFontButton. It's an Android button with built in support for an IconicDroid background, customizable via plain XML. It's a little rough around the edges, but worked for my purposes. That said, I'm happy to make changes. If we merge this, we should consider updating the demo to show the new functionality simply by adding the following to a layout file:

<com.atermenji.android.iconicdroid.IconicFontButton
    style="@style/IconicFontButton"
    app:iconUtf="@string/awesome_plus_square_o"
    app:font="awesome" />

@niedzielski
Copy link
Author

Rebased. I realize this commit is a starting point but I think it's a valuable direction for the library to go. Let me know what you think or changes are needed to get this in. Thanks.

@atermenji
Copy link
Owner

@niedzielski thanks a lot, I'll take a look at your commits soon, when I'll manage to find some free time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants