Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add horizontalrule in defaultElementRenderers #11

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Sen-442b
Copy link

@Sen-442b Sen-442b commented Aug 3, 2024

No description provided.

@mrclay
Copy link

mrclay commented Aug 8, 2024

This is welcomed.

Separate question: Should we not check for typeof elementRenderers[node.type] === "function" and just call it, so users can work around this library being out of date with Lexical?

@Sen-442b
Copy link
Author

This is welcomed.

Separate question: Should we not check for typeof elementRenderers[node.type] === "function" and just call it, so users can work around this library being out of date with Lexical?

Yes, that's a good approach to make it more flexible. We could work on implementing this if the maintainers are open to further discussion about it.

@ryangall7
Copy link

Lets get this merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants