Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/timer #37

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Feature/timer #37

wants to merge 5 commits into from

Conversation

raphael-nk
Copy link

I added a kind of timer in the project promiviz

@vercel
Copy link

vercel bot commented Oct 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
promiviz ✅ Ready (Inspect) Visit Preview Oct 21, 2022 at 6:30PM (UTC)

@atapas
Copy link
Owner

atapas commented Oct 17, 2022

Hi

Thanks for putting this.

A few feedback...

  • The look and feel of the timer display can be simpler. I have provided a suggestion in the below image but you can do much better there.

  • I see a bug. As in the screenshot below, you can see the timer shouldn't go tat much count right?

image

Copy link
Owner

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided comments.

@raphael-nk
Copy link
Author

raphael-nk commented Oct 17, 2022 via email

@atapas
Copy link
Owner

atapas commented Nov 14, 2022

Visit Preview

@raphael-nk Can you please take care of the UI how I have suggested?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants