Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add browser version of package and write docs for it #596

Merged
merged 6 commits into from
Sep 12, 2022
Merged

refactor: add browser version of package and write docs for it #596

merged 6 commits into from
Sep 12, 2022

Conversation

magicmatatjahu
Copy link
Member

Description

  • Add webpack configuration for browser version of package
  • Add tests for browser version
  • Update Readme.md
  • Update source code for better treeshaking - especially use directly supported JSON Schemas

cc @smoya

Related issue(s)
Part of #481
Part of #482

@magicmatatjahu magicmatatjahu added enhancement New feature or request 📑 docs labels Sep 7, 2022
@magicmatatjahu magicmatatjahu marked this pull request as ready for review September 8, 2022 10:00
smoya
smoya reviewed Sep 8, 2022
View reviewed changes
src/constants.ts Outdated Show resolved Hide resolved
smoya
smoya reviewed Sep 9, 2022
View reviewed changes
src/constants.ts Outdated Show resolved Hide resolved
smoya
smoya approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@magicmatatjahu
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit b2b8e2a into asyncapi:next-major Sep 12, 2022
@magicmatatjahu magicmatatjahu deleted the next/browser-version branch September 12, 2022 13:53
@magicmatatjahu magicmatatjahu mentioned this pull request Sep 12, 2022
Closed
20 tasks
magicmatatjahu added a commit to magicmatatjahu/parser-js that referenced this pull request Oct 3, 2022
@magicmatatjahu
refactor: add browser version of package and write docs for it (async…
565d8ea 
…api#596)
derberg pushed a commit that referenced this pull request Oct 4, 2022
@magicmatatjahu @derberg
refactor: add browser version of package and write docs for it (#596)
8e57fb9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoya smoya smoya approved these changes

@fmvilas fmvilas Awaiting requested review from fmvilas fmvilas is a code owner

@jonaslagoni jonaslagoni Awaiting requested review from jonaslagoni jonaslagoni is a code owner

@derberg derberg Awaiting requested review from derberg derberg is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
📑 docs enhancement New feature or request ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@magicmatatjahu @smoya @asyncapi-bot