Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: cleanup unnecessary warning #71

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Oct 10, 2024

Fixes #70, see discussion there for context and current behaviour.

@bsipocz bsipocz added the bug Something isn't working label Oct 10, 2024
Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found small typo. Once that is fixed, I will approve. Thanks!

sphinx_astropy/conf/v1.py Outdated Show resolved Hide resolved
sphinx_astropy/conf/v2.py Outdated Show resolved Hide resolved
@pllim pllim added this to the v2.0 milestone Oct 10, 2024
Co-authored-by: P. L. Lim <[email protected]>
Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pllim pllim merged commit d0e263c into astropy:main Oct 10, 2024
9 checks passed
@pllim
Copy link
Member

pllim commented Oct 10, 2024

Do you need a release?

@pllim pllim modified the milestones: v2.0, v1.9.2 Oct 10, 2024
@bsipocz
Copy link
Member Author

bsipocz commented Oct 10, 2024

nope, it can wait.

@bsipocz bsipocz deleted the BUG_remove_warning branch October 10, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: warning should not be shown to packages not using the plot directive
2 participants