cleanup comments to self

astropy · Nov 27, 2019 · 07e22b7 · 07e22b7
1 parent 4fb90c7
commit 07e22b7
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 8 deletions.
diff --git a/halotools/mock_observables/large_scale_density/large_scale_density_spherical_volume.py b/halotools/mock_observables/large_scale_density/large_scale_density_spherical_volume.py
@@ -18,7 +18,6 @@
 np.seterr(divide='ignore', invalid='ignore')  # ignore divide by zero in e.g. DD/RR
 
 
-# cbx: I think all the code here could pretty easily be replaced with that of `large_scale_density_spherical_annulus`
 def large_scale_density_spherical_volume(sample, tracers, radius,
         period=None, sample_volume=None, num_threads=1, approx_cell1_size=None,
         norm_by_mean_density=False):

diff --git a/halotools/mock_observables/pairwise_velocities/mean_radial_velocity_vs_r.py b/halotools/mock_observables/pairwise_velocities/mean_radial_velocity_vs_r.py
@@ -169,7 +169,7 @@ def mean_radial_velocity_vs_r(sample1, velocities1,
     """
     result = _process_args(sample1, velocities1, sample2, velocities2,
         rbins_absolute, rbins_normalized, normalize_rbins_by,
-        period, num_threads, approx_cell1_size, approx_cell2_size, None)
+        period, num_threads, approx_cell1_size, approx_cell2_size)
 
     sample1, velocities1, sample2, velocities2, max_rbins_absolute, period,\
         num_threads, _sample1_is_sample2, PBCs, \
@@ -230,7 +230,7 @@ def mean_radial_velocity_vs_r(sample1, velocities1,
 
 def _process_args(sample1, velocities1, sample2, velocities2,
         rbins_absolute, rbins_normalized, normalize_rbins_by,
-        period, num_threads, approx_cell1_size, approx_cell2_size, seed):
+        period, num_threads, approx_cell1_size, approx_cell2_size):
     """
     Private method to do bounds-checking on the arguments passed to
     `~halotools.mock_observables.pairwise_velocity_stats`.

diff --git a/halotools/mock_observables/pairwise_velocities/radial_pvd_vs_r.py b/halotools/mock_observables/pairwise_velocities/radial_pvd_vs_r.py
@@ -167,7 +167,7 @@ def radial_pvd_vs_r(sample1, velocities1,
     """
     result = _process_args(sample1, velocities1, sample2, velocities2,
         rbins_absolute, rbins_normalized, normalize_rbins_by,
-        period, num_threads, approx_cell1_size, approx_cell2_size, None)
+        period, num_threads, approx_cell1_size, approx_cell2_size)
 
     sample1, velocities1, sample2, velocities2, max_rbins_absolute, period,\
         num_threads, _sample1_is_sample2, PBCs, \

diff --git a/halotools/mock_observables/pairwise_velocities/velocity_marked_npairs_3d.py b/halotools/mock_observables/pairwise_velocities/velocity_marked_npairs_3d.py
@@ -289,7 +289,6 @@ def _func_signature_int_from_vel_weight_func_id(weight_func_id):
         msg = "\n weight_func_id parameter must be an integer ID of a weighting function."
         raise HalotoolsError(msg)
 
-    # cbx: seriousl you need 6 weights?
     elif weight_func_id == 1:
         return 6
     elif weight_func_id == 2:

diff --git a/halotools/mock_observables/two_point_clustering/angular_tpcf.py b/halotools/mock_observables/two_point_clustering/angular_tpcf.py
@@ -184,7 +184,7 @@ def area_spherical_cap(chord):
         elif randoms is None:
 
             # set the number of randoms equal to the number of points in sample1
-            # cbx: Why not use much more? Less noise at no cost right?
+            # cbx: Maybe stupid question but why not use much more? Less noise at no cost right?
             NR = len(sample1)
 
             # do area calculations
@@ -202,7 +202,7 @@ def area_spherical_cap(chord):
             D2R = N2*(da*rho2)
 
             # calculate the random-random pairs.
-            # cbx: This should be NR(NR-1) if we are doing an autocorr
+            # cbx: This should be NR(NR-1) if we are doing an autocorr I think? Maybe it doesn't matter.
             rhor = NR**2/global_area
             RR = (da*rhor)
 
@@ -239,7 +239,6 @@ def pair_counts(sample1, sample2, chord_bins,
         return D1D1, D1D2, D2D2
 
     # What needs to be done?
-    # cbx: do_DD is never used
     do_DD, do_DR, do_RR = _TP_estimator_requirements(estimator)
 
     # How many points are there (for normalization purposes)?