Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address failing benchmarks #532

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Address failing benchmarks #532

merged 1 commit into from
Dec 18, 2024

Conversation

delucchi-cmu
Copy link
Contributor

No description provided.

Copy link

Before [78fa073] After [84ed944] Ratio Benchmark (Parameter)
14.2±0.4ms 14.4±0.1ms 1.01 benchmarks.time_box_filter_on_partition
28.5±0.6ms 28.6±0.7ms 1 benchmarks.time_polygon_search
12.5±0.06s 12.4±0.05s 0.99 benchmarks.time_create_large_catalog
85.6±0.9ms 84.6±2ms 0.99 benchmarks.time_kdtree_crossmatch
1.86±0.02s 1.82±0.02s 0.98 benchmarks.time_create_midsize_catalog

Click here to view all benchmarks.

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.38%. Comparing base (78fa073) to head (d97a925).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #532   +/-   ##
=======================================
  Coverage   97.38%   97.38%           
=======================================
  Files          43       43           
  Lines        1720     1720           
=======================================
  Hits         1675     1675           
  Misses         45       45           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gitosaurus gitosaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delucchi-cmu delucchi-cmu merged commit c80c318 into main Dec 18, 2024
10 of 11 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/benchmark branch December 18, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants