Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on Windows OS. #522

Merged
merged 4 commits into from
Dec 6, 2024
Merged

Test on Windows OS. #522

merged 4 commits into from
Dec 6, 2024

Conversation

delucchi-cmu
Copy link
Contributor

@delucchi-cmu delucchi-cmu commented Dec 6, 2024

Now that we don't depend on healpy, everything should run well on Windows. This adds a test to confirm that.

lsst-sphgeom is not available for windows, so this makes it an optional dependency, conditionally disabling tests that require it.

See: astronomy-commons/hats#440

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.40%. Comparing base (dd92005) to head (c151c8b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #522   +/-   ##
=======================================
  Coverage   97.40%   97.40%           
=======================================
  Files          43       43           
  Lines        1697     1697           
=======================================
  Hits         1653     1653           
  Misses         44       44           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 6, 2024

Before [dd92005] After [842bb2c] Ratio Benchmark (Parameter)
failed failed n/a benchmarks.time_box_filter_on_partition
failed failed n/a benchmarks.time_polygon_search
92.9±1ms 94.7±1ms 1.02 benchmarks.time_kdtree_crossmatch
2.17±0s 2.14±0.03s 0.99 benchmarks.time_create_midsize_catalog
14.6±0.03s 14.3±0.1s 0.98 benchmarks.time_create_large_catalog

Click here to view all benchmarks.

@delucchi-cmu delucchi-cmu merged commit 38a77f9 into main Dec 6, 2024
12 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/windows branch December 6, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants