Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nested-dask to v0.3.0 #493

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Update nested-dask to v0.3.0 #493

merged 2 commits into from
Nov 7, 2024

Conversation

hombit
Copy link
Contributor

@hombit hombit commented Nov 6, 2024

Currently we have a single test failure when querying with column names that include a space. Here is the corresponding Nested-Pandas issue: lincc-frameworks/nested-pandas#174

@hombit hombit requested a review from delucchi-cmu November 6, 2024 22:59
Copy link

github-actions bot commented Nov 6, 2024

Before [5015b9b] After [98ad26d] Ratio Benchmark (Parameter)
14.5±0.04s 14.7±0.05s 1.02 benchmarks.time_create_large_catalog
2.15±0.01s 2.20±0.04s 1.02 benchmarks.time_create_midsize_catalog
104±2ms 105±0.5ms 1.01 benchmarks.time_kdtree_crossmatch
31.8±0.5ms 32.0±2ms 1.01 benchmarks.time_polygon_search
16.3±0.09ms 16.0±0.6ms 0.98 benchmarks.time_box_filter_on_partition

Click here to view all benchmarks.

@gitosaurus gitosaurus self-requested a review November 6, 2024 23:10
Copy link
Contributor

@gitosaurus gitosaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.67%. Comparing base (5015b9b) to head (b0bc8a3).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #493   +/-   ##
=======================================
  Coverage   97.67%   97.67%           
=======================================
  Files          39       39           
  Lines        1550     1550           
=======================================
  Hits         1514     1514           
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hombit hombit merged commit 10de44d into main Nov 7, 2024
11 checks passed
@hombit hombit deleted the nested-dask-v0.3.0 branch November 7, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants