Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added kwargs on hats.read_hats to pass http headers #485

Closed
wants to merge 1 commit into from

Conversation

Schwarzam
Copy link
Contributor

Added kwargs to hats.read_hats for HTTP headers support

This is related to
astronomy-commons/hats#411

And issue
astronomy-commons/hats#410

Even without the pull request in the hats repo, the code in this pull request works.

This code functions as expected, even without the corresponding pull request in the hats repository.
Tested with and without headers.

Copy link

github-actions bot commented Nov 1, 2024

Before [5fbe2e2] After [4c5fe02] Ratio Benchmark (Parameter)
30.1±0.6ms 30.5±0.6ms 1.01 benchmarks.time_polygon_search
14.5±0.02s 14.4±0.03s 0.99 benchmarks.time_create_large_catalog
2.18±0.02s 2.15±0.01s 0.99 benchmarks.time_create_midsize_catalog
102±0.8ms 101±0.6ms 0.99 benchmarks.time_kdtree_crossmatch
16.9±2ms 15.9±0.4ms 0.94 benchmarks.time_box_filter_on_partition

Click here to view all benchmarks.

@Schwarzam Schwarzam closed this Nov 1, 2024
@delucchi-cmu delucchi-cmu deleted the hats#410_headers_feature branch November 1, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant