Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update output from docs. Update path to hats catalogs. #445

Merged
merged 10 commits into from
Oct 25, 2024

Conversation

delucchi-cmu
Copy link
Contributor

@delucchi-cmu delucchi-cmu commented Oct 18, 2024

Closes #451.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

github-actions bot commented Oct 18, 2024

Before [84465fa] After [bf022b7] Ratio Benchmark (Parameter)
18.3±0.2ms 18.4±0.3ms 1.01 benchmarks.time_box_filter_on_partition
107±0.7ms 107±0.8ms 1 benchmarks.time_kdtree_crossmatch
2.20±0.02s 2.17±0.01s 0.99 benchmarks.time_create_midsize_catalog
33.0±0.9ms 32.7±0.4ms 0.99 benchmarks.time_polygon_search
14.8±0.1s 14.4±0.01s 0.97 benchmarks.time_create_large_catalog

Click here to view all benchmarks.

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.71%. Comparing base (84465fa) to head (0d7df8d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #445   +/-   ##
=======================================
  Coverage   97.71%   97.71%           
=======================================
  Files          44       44           
  Lines        1618     1619    +1     
=======================================
+ Hits         1581     1582    +1     
  Misses         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@smcguire-cmu smcguire-cmu force-pushed the delucchi/docs branch 2 times, most recently from c9c842f to fe31502 Compare October 22, 2024 18:23
Copy link
Member

@nevencaplar nevencaplar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@delucchi-cmu delucchi-cmu merged commit f1a3713 into main Oct 25, 2024
11 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/docs branch October 25, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

to_hats fails with str argument
4 participants