Skip to content

Commit

Permalink
Fix CI wrt broken coverage upload artifact (#1210)
Browse files Browse the repository at this point in the history
Apparently the GitHub action https://github.com/actions/upload-artifact
released a breaking change
actions/upload-artifact#602 (not following
semver guidelines) which is affecting our CodeCov job as it's no longer
able to download artifacts that were supposed to be uploaded from our
tests in earlier jobs in the CI.

According to suggestion in
https://github.com/actions/upload-artifact/pull/607/files, set include
include-hidden-files: true, so that our workflow continues to work as it
was before.
  • Loading branch information
pankajkoti authored Sep 19, 2024
1 parent e71d47b commit c5e8544
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ jobs:
with:
name: coverage-unit-test-${{ matrix.python-version }}-${{ matrix.airflow-version }}
path: .coverage
include-hidden-files: true

Run-Integration-Tests:
needs: Authorize
Expand Down Expand Up @@ -181,6 +182,7 @@ jobs:
with:
name: coverage-integration-test-${{ matrix.python-version }}-${{ matrix.airflow-version }}
path: .coverage
include-hidden-files: true

Run-Integration-Tests-Expensive:
needs: Authorize
Expand Down Expand Up @@ -252,6 +254,7 @@ jobs:
with:
name: coverage-integration-expensive-test-${{ matrix.python-version }}-${{ matrix.airflow-version }}
path: .coverage
include-hidden-files: true

env:
AIRFLOW_HOME: /home/runner/work/astronomer-cosmos/astronomer-cosmos/
Expand Down Expand Up @@ -319,6 +322,7 @@ jobs:
with:
name: coverage-integration-sqlite-test-${{ matrix.python-version }}-${{ matrix.airflow-version }}
path: .coverage
include-hidden-files: true

env:
AIRFLOW_HOME: /home/runner/work/astronomer-cosmos/astronomer-cosmos/
Expand Down Expand Up @@ -395,6 +399,7 @@ jobs:
with:
name: coverage-integration-dbt-1-5-4-test-${{ matrix.python-version }}-${{ matrix.airflow-version }}
path: .coverage
include-hidden-files: true

env:
AIRFLOW_HOME: /home/runner/work/astronomer-cosmos/astronomer-cosmos/
Expand Down Expand Up @@ -538,6 +543,7 @@ jobs:
with:
name: coverage-integration-kubernetes-test-${{ matrix.python-version }}-${{ matrix.airflow-version }}
path: .coverage
include-hidden-files: true

Code-Coverage:
if: github.event.action != 'labeled'
Expand Down

0 comments on commit c5e8544

Please sign in to comment.