Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R Tree partitioning #87

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

R Tree partitioning #87

wants to merge 19 commits into from

Conversation

mayurdb
Copy link
Contributor

@mayurdb mayurdb commented Aug 2, 2018

Work in Progress. Still a lot to do

@codecov-io
Copy link

codecov-io commented Aug 19, 2018

Codecov Report

Merging #87 into master will decrease coverage by 96.37%.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #87       +/-   ##
========================================
- Coverage   96.37%    0%   -96.38%     
========================================
  Files          32    29        -3     
  Lines        1240    30     -1210     
  Branches      218     4      -214     
========================================
- Hits         1195     0     -1195     
+ Misses         45    30       -15
Flag Coverage Δ
#python 100% <ø> (+5.69%) ⬆️
#scala 0% <0%> (-97.25%) ⬇️
Impacted Files Coverage Δ
...cala/com/spark3d/geometryObjects/BoxEnvelope.scala 0% <ø> (-98.67%) ⬇️
...park3d/spatialPartitioning/Rtree/NonLeafNode.scala 0% <0%> (ø)
...d/spatialPartitioning/Rtree/RTreePartitioner.scala 0% <0%> (ø)
...m/spark3d/spatialPartitioning/Rtree/LeafNode.scala 0% <0%> (ø)
.../spatialPartitioning/Rtree/RTreePartitioning.scala 0% <0%> (ø)
.../spark3d/spatialPartitioning/Rtree/BaseRTree.scala 0% <0%> (ø)
...park3d/spatialPartitioning/OnionPartitioning.scala 0% <0%> (-100%) ⬇️
...ark3d/spatialPartitioning/OctreePartitioning.scala 0% <0%> (-100%) ⬇️
...in/scala/com/spark3d/geometryObjects/Point3D.scala 0% <0%> (-100%) ⬇️
src/main/scala/com/spark3d/utils/GridType.scala 0% <0%> (-100%) ⬇️
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ef3cf8...ac2527a. Read the comment docs.

@JulienPeloton
Copy link
Member

Hi @mayurdb !

What is the status of this PR? Do you plan on adding more code/tests?

Julien

@mayurdb
Copy link
Contributor Author

mayurdb commented Sep 10, 2018

Hi, yes yes. Extremely sorry for the delay. I'll update the PR with all the changes by Thursday evening.

@JulienPeloton
Copy link
Member

OK great! No rush though, I just wanted to check the status :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants