Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add light travel correction for ssHG1G2 #458

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Add light travel correction for ssHG1G2 #458

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3263aa3
Add light travel correction for SSHG1G2
JulienPeloton Oct 28, 2024
feb51fb
Use 0.29.7 release for fink-utils in the CI
JulienPeloton Oct 28, 2024
a336e02
Clean CI job
JulienPeloton Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion fink_science/ssoft/processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
from pyspark.sql.types import MapType, FloatType, StringType

from fink_utils.sso.utils import get_miriade_data
from fink_utils.sso.utils import compute_light_travel_correction
from fink_utils.sso.spins import estimate_sso_params
from fink_utils.sso.periods import estimate_synodic_period

Expand Down Expand Up @@ -369,6 +370,8 @@ def estimate_sso_params_spark(ssnamenr, magpsf, sigmapsf, jd, fid, ra, dec, meth

# Full inversion using pre-computed SHG1G2 & period
if (model.values[0] == "SSHG1G2") and ~np.isnan(outdic["period"]):
jd_lt = compute_light_travel_correction(pdf["i:jd"], pdf["Dobs"])

# TODO: understand if 2*period value (double-peaked lightcurve) is required
# TODO: extend `estimate_sso_parameters` to take p0 per filter for H & G
p0 = [
Expand All @@ -392,7 +395,7 @@ def estimate_sso_params_spark(ssnamenr, magpsf, sigmapsf, jd, fid, ra, dec, meth
pdf['i:fid'].values,
ra=np.deg2rad(pdf['i:ra'].values),
dec=np.deg2rad(pdf['i:dec'].values),
jd=pdf["i:jd"].to_numpy(),
jd=jd_lt.to_numpy(),
p0=p0,
bounds=MODELS['SSHG1G2']['bounds'],
model='SSHG1G2',
Expand Down
Loading