Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SLSN] Catch convergence errors #362

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Conversation

JulienPeloton
Copy link
Member

IMPORTANT: Please create an issue first before opening a Pull Request.
Linked to issue(s): Closes #361

@JulienPeloton JulienPeloton added bug Something isn't working elasticc AGN slsn labels Dec 12, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b855ff1) 56.35% compared to head (d3e095e) 56.40%.

❗ Current head d3e095e differs from pull request most recent head 88ddffc. Consider uploading reports for the commit 88ddffc to get more accurate results

Files Patch % Lines
fink_science/slsn/feature_extraction.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #362      +/-   ##
==========================================
+ Coverage   56.35%   56.40%   +0.05%     
==========================================
  Files          36       36              
  Lines        1629     1631       +2     
==========================================
+ Hits          918      920       +2     
  Misses        711      711              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JulienPeloton JulienPeloton merged commit 6c2656b into master Dec 12, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AGN bug Something isn't working elasticc slsn
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SLSN] LinalgError
2 participants