Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply the condition to remove unwanted objects with null features #348

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

JulienPeloton
Copy link
Member

IMPORTANT: Please create an issue first before opening a Pull Request.
Linked to issue(s): Closes #347

What changes were proposed in this pull request?

Apply the condition to remove unwanted objects with null features in the Early SN Ia module.

How was this patch tested?

Manually

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (faff14b) 53.44% compared to head (32fde57) 53.40%.

❗ Current head 32fde57 differs from pull request most recent head e28f1e5. Consider uploading reports for the commit e28f1e5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #348      +/-   ##
==========================================
- Coverage   53.44%   53.40%   -0.04%     
==========================================
  Files          33       33              
  Lines        1510     1511       +1     
==========================================
  Hits          807      807              
- Misses        703      704       +1     
Files Coverage Δ
fink_science/__init__.py 100.00% <100.00%> (ø)
fink_science/random_forest_snia/processor.py 30.92% <0.00%> (-0.33%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JulienPeloton JulienPeloton merged commit a08875d into master Oct 11, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Candidates with null features are not discarded
2 participants