Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces some performance improvements:
Medium object (~10 alerts) remain dominated by data manipulation
What could be optimised:
with_constellation
(60ms),extract_fink_classification_
(17ms),convert_datatype
(40ms) -- but I note thatgateway.jvm.com.Lomikel.HBaser.HBaseClient
peaks at 130ms (difficult to beat that). Large objects (>1000 alerts) starts to feel HBase data transfer:Main route performance
The main route performance for a medium size object (14 alerts, about 130 columns):
Requesting cutouts is costly! We have 14 alerts, which is about 0.25 second per cutout. Note that requesting 3 cutouts is faster then 3 times 1 cutout, as what drives the cost is to load the full block in HDFS in memory (see this discussion about the strategy behind).
Note that for lightcurve data, the time is fortunately not linear with the number of alerts per object: