Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the restrictions of the observation area #174

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

Knispel2
Copy link
Collaborator

No description provided.

@Knispel2 Knispel2 requested a review from JulienPeloton March 12, 2024 17:26
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.39%. Comparing base (b2547b0) to head (32c8474).
Report is 3 commits behind head on master.

❗ Current head 32c8474 differs from pull request most recent head 8d630c3. Consider uploading reports for the commit 8d630c3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
- Coverage   70.69%   69.39%   -1.31%     
==========================================
  Files          19       20       +1     
  Lines         686      722      +36     
==========================================
+ Hits          485      501      +16     
- Misses        201      221      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JulienPeloton JulienPeloton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Knispel2 -- it looks good to me. Out of curiosity, why do you want to change the observation area?

@Knispel2
Copy link
Collaborator Author

Thanks @Knispel2 -- it looks good to me. Out of curiosity, why do you want to change the observation area?

Six months have passed, and objects that were previously visible at night are now visible during the day. We need to change the right ascension

@JulienPeloton JulienPeloton merged commit 4dfd026 into master Mar 13, 2024
3 checks passed
@Knispel2 Knispel2 deleted the ad/new_area_params branch March 13, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants