Reorganisation & visualisation #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, the test suite has been expanded and the coverage has been increased. |
This was referenced Jan 19, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please create an issue first before opening a Pull Request.
Linked to issue(s): #34
What changes were proposed in this pull request?
This PR introduces a new module for visualisation (
visualisation.py), a new class to manipulate alerts (class AlertReader), two new CLI (fink_alert_viewerandfink_consumer), and reorganise the existing modules to simplify the structure.fink_alert_viewerallows to quickly inspect an alert from the terminalfink_consumerallows to poll new alerts from Fink from the terminal. It can consumate and save alerts, but there is no handler capability yet (see Allow handler for fink_consumer #35 ).How was this patch tested?
Manually and CI. A new notebook has been pushed also.