Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update display and write for MMA schema #177

Merged
merged 16 commits into from
Jul 19, 2023
Merged

Update display and write for MMA schema #177

merged 16 commits into from
Jul 19, 2023

Conversation

JulienPeloton
Copy link
Member

@JulienPeloton JulienPeloton commented Jun 26, 2023

IMPORTANT: Please create an issue first before opening a Pull Request.
Linked to issue(s): #176

Now users can subscribe to MMA channels. Call remains the same:

fink_consumer.py --display -limit 10 --save -outdir MMA_DB

To do:

  • Automatically create DB folder
  • Allow restarting from the first offset

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2023

Codecov Report

Patch coverage: 66.66% and no project coverage change.

Comparison is base (51f5dfc) 71.57% compared to head (a08459c) 71.57%.

❗ Current head a08459c differs from pull request most recent head 1f27045. Consider uploading reports for the commit 1f27045 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #177   +/-   ##
=======================================
  Coverage   71.57%   71.57%           
=======================================
  Files           7        7           
  Lines         380      380           
=======================================
  Hits          272      272           
  Misses        108      108           
Impacted Files Coverage Δ
fink_client/consumer.py 53.33% <0.00%> (ø)
fink_client/__init__.py 100.00% <100.00%> (ø)
fink_client/avroUtils.py 84.82% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JulienPeloton
Copy link
Member Author

JulienPeloton commented Jul 19, 2023

Hum, the fastavro dependencies is getting more complicated:

  • We have to use <=1.6.0 as higher versions are not compatible with schemas sent by the telescope
  • only version >= 1.8.2 are compatible with the latest Cython version (3).

So if we want to keep using 1.6.0, we need to use Cython<3 and a build isolation... But this cannot be specified from the requirements.txt since the latest pip upgrade 😭

@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JulienPeloton JulienPeloton merged commit a47f718 into master Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants