Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SSOFT generation #880

Merged
merged 10 commits into from
Oct 9, 2024
Merged

Update SSOFT generation #880

merged 10 commits into from
Oct 9, 2024

Conversation

JulienPeloton
Copy link
Member

IMPORTANT: Please create an issue first before opening a Pull Request.
Linked to issue(s): Closes #878

What changes were proposed in this pull request?

The SSOFT is now a science module in fink-science rather than a module in fink-spins. In addition, the SSOFT contains estimation of the synodic period. Need fink-utils>=0.21 and fink-science>=3.16

How was this patch tested?

Manually

@JulienPeloton JulienPeloton added this to the 3.2 milestone Sep 3, 2024
Copy link

sonarcloud bot commented Sep 4, 2024

Copy link

sonarcloud bot commented Oct 9, 2024

@JulienPeloton JulienPeloton merged commit 553e430 into master Oct 9, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update SSOFT computation with period estimation
1 participant