Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

799 avoid image build when not needed #801

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

fjammes
Copy link
Contributor

@fjammes fjammes commented Jan 25, 2024

IMPORTANT: Please create an issue first before opening a Pull Request.
Linked to issue(s): see "Development" section on the right

What changes were proposed in this pull request?

During the Ci process, ciux will not build the image if no code change has been made in the current commit.
Some limitations:

  • this does not work for CI pipeline triggered by a PR, because git repository state in the CI machine is non-standard
  • the image for the latest commit which introduce a code change must have been pushed to official registry

How was this patch tested?

In the CI on the self-hosted runner, some random errors were observed...

@fjammes fjammes self-assigned this Jan 25, 2024
@fjammes fjammes linked an issue Jan 25, 2024 that may be closed by this pull request
@fjammes fjammes force-pushed the 799-avoid-image-build-when-not-needed branch 3 times, most recently from 76cd1d2 to d3a469d Compare January 31, 2024 09:22
@fjammes fjammes force-pushed the 799-avoid-image-build-when-not-needed branch 4 times, most recently from 398a0f3 to f907c72 Compare February 14, 2024 18:49
Do not build the image is source code has not changed.
And also:
- Remove strimzi/minio install scripts prior to argocd
- Add source code pathes to ciux
- Remove 'minimal' parameter
- Add suppport for image scan
- Retrieve image url from ciuxconfig for e2e tests
- Implement suffix image support for self-hosted workflows
- Implement common workflow for CI and self-hosted
- Promote remote image by tagging it with skopeo
- Install argo-workflow with ktbx
- Bump ktbx to v1.1.1-rc13
- Parametrize kind version on ci
- Increase startup wait time for broker pods
- Add support for private registry certificates
- Improve image push and tag in CI
- Improve fink startup check
- Bump ciux to v1.1.1-rc17 (increase argo wait timeout)
@fjammes fjammes force-pushed the 799-avoid-image-build-when-not-needed branch from 23f81cd to ec69eeb Compare February 16, 2024 10:47
@fjammes fjammes force-pushed the 799-avoid-image-build-when-not-needed branch from f815f84 to 91d9285 Compare February 22, 2024 08:07
@fjammes fjammes marked this pull request as ready for review February 22, 2024 08:07
Copy link

sonarcloud bot commented Feb 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Member

@JulienPeloton JulienPeloton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fjammes -- it looks good to me.

@fjammes fjammes merged commit fb35542 into master Feb 22, 2024
22 checks passed
@fjammes fjammes deleted the 799-avoid-image-build-when-not-needed branch February 22, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid image build when not needed
2 participants