Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Spark 3.4.1 #759

Merged
merged 24 commits into from
Nov 28, 2023
Merged

Update to Spark 3.4.1 #759

merged 24 commits into from
Nov 28, 2023

Conversation

JulienPeloton
Copy link
Member

@JulienPeloton JulienPeloton commented Nov 19, 2023

IMPORTANT: Please create an issue first before opening a Pull Request.
Linked to issue(s): Closes #758

Contains also:

@JulienPeloton JulienPeloton added the bug Something isn't working label Nov 19, 2023
@JulienPeloton JulienPeloton added this to the 3.2 milestone Nov 19, 2023
@JulienPeloton
Copy link
Member Author

Requires spark>=3.2

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (47e4b0f) 90% compared to head (4e20e5b) 90%.

Additional details and impacted files
@@          Coverage Diff          @@
##           master   #759   +/-   ##
=====================================
  Coverage      90%    90%           
=====================================
  Files          17     17           
  Lines         939    948    +9     
=====================================
+ Hits          847    857   +10     
+ Misses         92     91    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JulienPeloton JulienPeloton changed the title Add explicitly mode in the executePlan args Update to Spark 3.4.1 Nov 21, 2023
JulienPeloton and others added 2 commits November 27, 2023 09:22
* New bin to generate the SSOFT

* Update args

* Update type of frac

* Missing deps

* Missing deps

* Fix bug in the argument name

* Fix typo

* Take the number of cores differently

* PEP89
* add fast transient module to the science pipeline

* fix DataFrame
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JulienPeloton
Copy link
Member Author

All tests OK, including the self-hosted ones, but the GHA:

##[debug]Evaluating condition for step: 'Check results'
##[debug]Evaluating: success()
##[debug]Evaluating success:
##[debug]=> true
##[debug]Result: true
##[debug]Starting: Check results
##[debug]Loading inputs
##[debug]Loading env
Run ./itest/check-results.sh
##[debug]/usr/bin/bash -e /home/runner/work/_temp/ec3e39b3-7317-421c-877d-a6ee9d20e29f.sh
error: timed out waiting for the condition on topics
Error: Process completed with exit code 1.
##[debug]Finishing: Check results

This error seems a constant unfortunately, and unrelated to the code :-(

@JulienPeloton JulienPeloton merged commit 3a058ca into master Nov 28, 2023
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Method executePlan([class org.apache.spark.sql.execution.datasources.LogicalRelation]) does not exist
2 participants