Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug self hosted runner #749

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Debug self hosted runner #749

merged 2 commits into from
Oct 4, 2023

Conversation

fjammes
Copy link
Contributor

@fjammes fjammes commented Oct 4, 2023

What changes were proposed in this pull request?

Minor fixes to CI workflow which fixes finkctl version management.

@fjammes fjammes force-pushed the debug-self-hosted-runner branch from 4d07052 to 39c3e3e Compare October 4, 2023 05:58
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (78403ba) 90% compared to head (acc8cce) 90%.

❗ Current head acc8cce differs from pull request most recent head 39c3e3e. Consider uploading reports for the commit 39c3e3e to get more accurate results

Additional details and impacted files
@@          Coverage Diff          @@
##           master   #749   +/-   ##
=====================================
  Coverage      90%    90%           
=====================================
  Files          20     20           
  Lines        1110   1110           
=====================================
  Hits          999    999           
  Misses        111    111           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fjammes fjammes merged commit 2b85239 into master Oct 4, 2023
16 checks passed
@JulienPeloton JulienPeloton added the k8s Kubernetes deployment label Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
k8s Kubernetes deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants