Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use stellar-core replay-in-memory catchup mode #23

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Use stellar-core replay-in-memory catchup mode #23

wants to merge 18 commits into from

Conversation

charlie-wasp
Copy link
Collaborator

@charlie-wasp charlie-wasp commented Mar 27, 2020 •
edited
Loading

Addresses #20

This change is Reviewable

@charlie-wasp charlie-wasp marked this pull request as ready for review April 21, 2020 08:43
@charlie-wasp
Copy link
Collaborator Author

@nebolsin I revisited this PR, it seems to me that it's ready for review already. Here I used stellar-core replay-in-memory mode only in the export command. Not sure at the moment, can we adapt it for real-time ingesting at all 🤔

@sonarcloud
Copy link

sonarcloud bot commented Aug 14, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

nebolsin
nebolsin reviewed Oct 27, 2020
View reviewed changes
es/ledger_serializer.go
feeRows := make([]db.TxFeeHistoryRow, len(meta.V0.TxSet.Txs))

for i, txe := range meta.V0.TxSet.Txs {
txHash, hashErr := util.HashTransactionInEnvelope(txe, networkPassphrase)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@charlie-wasp looks like you forgot to include util.HashTransactionInEnvelope:

 go build -o dist/astrologer -v
github.com/astroband/astrologer/es
# github.com/astroband/astrologer/es
es/ledger_serializer.go:55:22: undefined: util.HashTransactionInEnvelope

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's weird, I include util package here. I don't have any build errors on my dev machine, I'll try to investigate this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@charlie-wasp yep, but there seems to be no HashTransactionInEnvelope method in github.com/astroband/astrologer/util package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nebolsin nebolsin nebolsin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charlie-wasp @nebolsin