Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix liabilities on ORM entities for Account and Trustline #209

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix liabilities on ORM entities for Account and Trustline #209

wants to merge 1 commit into from

Conversation

charlie-wasp
Copy link
Contributor

@charlie-wasp charlie-wasp commented Nov 13, 2020 •
edited by nebolsin
Loading

Resolves #207

This change is Reviewable

@charlie-wasp charlie-wasp requested a review from a team as a code owner November 13, 2020 10:13
@sonarcloud
Copy link

sonarcloud bot commented Nov 13, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 2 Code Smells

9.4% 9.4% Coverage
97.3% 97.3% Duplication

nebolsin
nebolsin requested changes Nov 13, 2020
View reviewed changes
Copy link
Member

@nebolsin nebolsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comment regarding keeping extension and ledgerext fields generic. Also it appears like there're some test failures in the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nebolsin nebolsin nebolsin requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure compatibility with stellar-core 15.x
2 participants
@charlie-wasp @nebolsin